Skip to content

Conversation

dh1tw
Copy link

@dh1tw dh1tw commented Sep 27, 2025

Recent versions of cmake require cmake_minimum_required(VERSION) to be higher than 3.5. Almost all CMakeLists.txt are already at VERSION=3.12. I found two more CMakeLists.txt where cmake_minimum_required had to be bumped to 3.12.

Volk can now be installed on MacOS with the Homebrew package manager. No more manual compiling needed. I updated the readme accordingly.

@AlexandreRouma
Copy link
Owner

Recent versions of cmake require cmake_minimum_required(VERSION) to be higher than 3.5. Almost all CMakeLists.txt are already at VERSION=3.12. I found two more CMakeLists.txt where cmake_minimum_required had to be bumped to 3.12.

Please PR to upstream instead:

Volk can now be installed on MacOS with the Homebrew package manager. No more manual compiling needed. I updated the readme accordingly.

I can't test right now as I don't have a mac to validate that this is the case. Please edit the PR to only keep this change and I'll only merge once I can check first hand that the brew version works properly.

@AlexandreRouma AlexandreRouma changed the title bump cmake_minimum_required Version to 3.12 Use brew volk package on MacOS instead of source build Sep 27, 2025
@dh1tw
Copy link
Author

dh1tw commented Sep 27, 2025

Thanks for the swift feedback. I just opened the PRs as suggested in the upstream repos, but I doubt that they will ever get merged. There hasn't been any activity in these repos for more than 5 years.

Sure, I can remove the edit to the CMakeLists.txt.

Would you prefer to add note in the readme.md that for modern versions of cmake, the flag -DCMAKE_POLICY_VERSION_MINIMUM=3.5 needs to be set?

Here is the link to the volk homebrew formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants