Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Update dependency express to v4.20.0 [SECURITY] #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 2, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.17.3 -> 4.20.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source

v4.18.3

Compare Source

==========

v4.18.2

Compare Source

===================

v4.18.1

Compare Source

===================

  • Fix hanging on large stack of sync routes

v4.18.0

Compare Source

===================


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title Update dependency express to v4.19.2 [SECURITY] Update dependency express to v4.19.2 [SECURITY] - autoclosed Apr 3, 2024
@renovate renovate bot closed this Apr 3, 2024
@renovate renovate bot deleted the renovate/npm-express-vulnerability branch April 3, 2024 13:16
@renovate renovate bot changed the title Update dependency express to v4.19.2 [SECURITY] - autoclosed Update dependency express to v4.19.2 [SECURITY] Apr 3, 2024
@renovate renovate bot restored the renovate/npm-express-vulnerability branch April 3, 2024 17:21
@renovate renovate bot reopened this Apr 3, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 6823c8a to 4d15e0a Compare April 3, 2024 17:22
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 4d15e0a to 136d162 Compare September 15, 2024 23:15
@renovate renovate bot changed the title Update dependency express to v4.19.2 [SECURITY] Update dependency express to v4.20.0 [SECURITY] Sep 15, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 882d632 to d65ad54 Compare October 9, 2024 09:27
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from d65ad54 to c5fe968 Compare October 18, 2024 18:23
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from c5fe968 to 0b0bf18 Compare December 2, 2024 11:53
@renovate renovate bot changed the title Update dependency express to v4.20.0 [SECURITY] Update dependency express to v4.20.0 [SECURITY] - autoclosed Dec 8, 2024
@renovate renovate bot closed this Dec 8, 2024
@renovate renovate bot deleted the renovate/npm-express-vulnerability branch December 8, 2024 18:41
@renovate renovate bot changed the title Update dependency express to v4.20.0 [SECURITY] - autoclosed Update dependency express to v4.20.0 [SECURITY] Dec 8, 2024
@renovate renovate bot reopened this Dec 8, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 0b0bf18 to 0a0ee1e Compare December 9, 2024 01:24
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 0a0ee1e to e25ce0a Compare December 23, 2024 12:09
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from e25ce0a to 5575517 Compare January 23, 2025 19:35
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 5575517 to 1e7b95b Compare February 9, 2025 15:59
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 1e7b95b to ef7afef Compare March 3, 2025 13:53
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from ef7afef to 0eb2b5a Compare March 11, 2025 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants