fix: switch Firebase OAuth from signInWithPopup to signInWithRedirect#8
Merged
Conversation
signInWithPopup is unreliable in production — popup blockers, privacy settings, and cross-window timing all cause auth/popup-closed-by-user. signInWithRedirect navigates the page to Firebase's auth handler and back; getRedirectResult() in the init useEffect captures the credential on return and exchanges it with the backend session API. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signInWithPopup is unreliable in production — popup blockers, privacy settings, and cross-window timing all cause auth/popup-closed-by-user. signInWithRedirect navigates the page to Firebase's auth handler and back; getRedirectResult() in the init useEffect captures the credential on return and exchanges it with the backend session API.
Summary
Changes
Validation
CHANGELOG.mdif neededNotes for Reviewers