Skip to content

[WIP] next #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NyxCode wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[WIP] next #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80b0b06
Change empty object to emit `Record<symbol, never>` (#431)
gustavo-shigueo Sep 13, 2025
d317570
Merge branch 'main' into next
NyxCode Dec 25, 2025
2832b4b
fix test
NyxCode Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion macros/src/types/unit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ pub(crate) fn empty_object(attr: &StructAttr, ts_name: Expr) -> DerivedTS {

DerivedTS {
crate_rename: crate_rename.clone(),
inline: quote!("Record<string, never>".to_owned()),
inline: quote!("Record<symbol, never>".to_owned()),
inline_flattened: None,
docs: attr.docs.clone(),
dependencies: Dependencies::new(crate_rename),
Expand Down
18 changes: 9 additions & 9 deletions ts-rs/tests/integration/docs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,15 @@ fn export_c() {
C::export().unwrap();

let expected_content = concat!(
"// This file was generated by [ts-rs](https://github.com/Aleph-Alpha/ts-rs). Do not edit this file manually.\n\n",
"/**\n",
" * Doc comment.\n",
" * Supports new lines.\n",
" *\n",
" * Testing\n",
" */\n",
"export type C = Record<string, never>;\n",
);
"// This file was generated by [ts-rs](https://github.com/Aleph-Alpha/ts-rs). Do not edit this file manually.\n\n",
"/**\n",
" * Doc comment.\n",
" * Supports new lines.\n",
" *\n",
" * Testing\n",
" */\n",
"export type C = Record<symbol, never>;\n",
);

let actual_content = fs::read_to_string(C::default_output_path().unwrap()).unwrap();

Expand Down
4 changes: 2 additions & 2 deletions ts-rs/tests/integration/unit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use ts_rs::TS;
struct Unit;

// serde_json serializes this to `{}`.
// The TS type best describing an empty object is `Record<string, never>`.
// The TS type best describing an empty object is `Record<symbol, never>`.
#[derive(TS)]
#[ts(export, export_to = "unit/")]
struct Unit2 {}
Expand All @@ -25,7 +25,7 @@ struct Unit4(());
#[test]
fn test() {
assert_eq!("type Unit = null;", Unit::decl());
assert_eq!("type Unit2 = Record<string, never>;", Unit2::decl());
assert_eq!("type Unit2 = Record<symbol, never>;", Unit2::decl());
assert_eq!("type Unit3 = never[];", Unit3::decl());
assert_eq!("type Unit4 = null;", Unit4::decl());
}