This repository was archived by the owner on Apr 19, 2024. It is now read-only.
Allow hiding password length#482
Open
szh wants to merge 1 commit into
Open
Conversation
Owner
|
This looks good - mind adding a test case to this file? |
Author
I don't see how to add a test case there since the prompt is the same. I think this would require some refactoring. Do you want me to attempt? |
Author
|
@AlecAivazis can we get this moving? |
Owner
|
Yea feel free to refactor the tests to verify this behavior |
Owner
|
Whoops! Wrong button 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses comments to #386
This PR allows you to set the
HideCharacterto a space which will be interpreted by the RuneReader to mean that the user input should not be echoed and that it shouldn't print a "mask" either.