Fix issues 1183, 1234, 1222, 1236 - #1443
Open
Miss-shelby wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1183 Closes #1234 Closes #1222 Closes #1236
Description
This pull request introduces a batch of critical reliability, architecture, and correctness improvements across the backend API, frontend clients, and smart contracts. These updates address multiple high-priority issues to ensure consistent mathematical operations, centralized validation, and predictable API behavior.
What's Included
1. Decimal-Aware Smart Contract Math (Closes #1183)
multitoken.rswhere operations mixed token amounts across different precisions (e.g., XLM at 7 decimals vs. USDC at 6/18 decimals).2. Idempotency Key Support for Mutating API Endpoints (Closes #1222)
Idempotency-Keyheader support to all mutating endpoints (POST, PUT, PATCH, DELETE).422 Unprocessable Entity.3. Standardized Stellar Address Validation (Closes #1234)
4. Structured API Error Codes (Closes #1236)
AppError.tsand the globalerrorHandler.tsto emit stable, machine-readable error codes alongside human-readable messages.Type of Change
Testing & Verification