Skip to content

feat: overlapping JWT keys, transactional boundaries, index audit, lo… - #1435

Open
Mikey-222 wants to merge 2 commits into
Akanimoh12:test-implement-dripsfrom
Mikey-222:feat/overlapping-keys-transactions-indexes-concurrency
Open

feat: overlapping JWT keys, transactional boundaries, index audit, lo…#1435
Mikey-222 wants to merge 2 commits into
Akanimoh12:test-implement-dripsfrom
Mikey-222:feat/overlapping-keys-transactions-indexes-concurrency

Conversation

@Mikey-222

Copy link
Copy Markdown
Contributor

Description

Closes #

Type of Change

Please mark the options that are relevant:

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧪 Tests (adding new tests or updating existing tests)
  • 📝 Documentation (changes to documentation/configs only)
  • 🚀 DevOps & CI/CD (changes to workflows, scripts, or templates)

Changes Made

How to Test

Checklist

💻 Smart Contract Changes (if applicable)

  • Running cargo fmt -- --check passes successfully.
  • Running cargo clippy -- -D warnings runs without any warnings.
  • All tests pass successfully using cargo test.
  • New unit or integration tests have been written to cover the changes.
  • No hardcoded values are present (e.g. addresses, fees) that should be configurable.

🎨 Frontend Changes (if applicable)

  • TypeScript compiles cleanly with no errors (npm run typecheck or npx tsc --noEmit).
  • Running npm run lint shows no linting errors.
  • The production build compiles successfully via npm run build.
  • Changes verified on local browser environment with Freighter/xBull/Albedo wallet.
  • Responsive design verified (tested on mobile, tablet, and desktop viewport sizes).
  • Keyboard navigation and accessibility (a11y) considerations are addressed.

⚙️ General

  • Code follows the project's coding standards and structure guidelines.
  • Self-reviewed the changes to ensure clean code with no commented-out code blocks.
  • No console.log or debug code remains in production files.
  • The branch is up-to-date with the main branch.

Screenshots / Demos (if applicable)

…st-update prevention

- JWT: support overlapping keys via JWT_SECRETS/JWT_CURRENT_KID, kid header, rotation with zero session loss, unknown kid rejected, single-secret backward compat, tests for sign/verify/rotation
- Transactions: audit every multi-row write path, wrap in prisma.$transaction with timeout/maxWait/isolationLevel, move external RPC/webhooks outside, document in backend/docs/TRANSACTIONS.md, add rollback test
- Indexes: audit every where/orderBy, add composite indexes ordered equality->range, migration adds concurrently, EXPLAIN before/after for top 5 queries, docs/INDEXES_AUDIT.md and INDEX_EXPLAIN.md
- Concurrency: atomic increment/decrement for counters, version column on Goal/Streak/AnalyticsDaily, optimistic retry with bounded retries, 100 parallel increments test, documented in ARCHITECTURE.md
@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@Mikey-222 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@gitguardian

gitguardian Bot commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
21431574 Triggered Generic Password 187f263 .github/workflows/pr-checks.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Akanimoh12

Copy link
Copy Markdown
Owner

Please resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants