feat(security): implement Redis-backed global and route-level rate limiting (#1223) - #1429
Open
Francis6-git wants to merge 1 commit into
Open
Conversation
|
@Francis6-git Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1223
Applies platform-wide, layered rate limiting using Redis to address unthrottled API endpoints across the backend. Integrates custom window tracking to ensure rate limits persist cleanly across horizontally scaled instances while preserving health check availability and identifying authenticated users.
Changes
1. Rate Limiting Middleware (
backend/src/middleware/rateLimiter.ts)ZADD,ZCOUNT,EXPIRE).user:<userId>when authenticated viaoptionalAuth, falling back toip:<clientIp>).2. Global & Mutating Route Protection (
backend/src/app.ts)/healthand sub-paths (*/health) from budget calculations.3. Stricter Per-Route Limits
auth.routes.ts): 30 requests / 1 min.ipfs.routes.ts): 20 requests / 1 min.search.routes.ts): 120 requests / 1 min.4. Response Headers & Error Consistency
Standardized response headers for both accepted and rejected requests:
RateLimit-Limit,RateLimit-Remaining,RateLimit-ResetX-RateLimit-*headers for backwards compatibility.Exceeded thresholds invoke
TooManyRequestsError, matching standard application error output:{ "error": { "code": "TOO_MANY_REQUESTS", "message": "Rate limit exceeded", "requestId": "..." } }Verification:
Closes #1223