Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js): notImplemented() automated #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(js): notImplemented() automated #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions registri.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ <h1 class="PortaleScuola">Portale Scuola</h1>
<h3 class="TuttiIRegistri">Tutti i registri</h3>
<ul class="Lista flex-grow-1">
<li class="Materia">
<button class="TitoloMateria">
<button class="TitoloMateria not-implemented">
<h4 class="Chimica">Chimica</h4>
</button>
</li>
<li class="Materia">
<button class="TitoloMateria">
<button class="TitoloMateria not-implemented">
<h4 class="aggiungi">+</h4>
</button>
</li>
Expand All @@ -61,13 +61,9 @@ <h4 class="aggiungi">+</h4>
<section class="VisualeLezione d-flex flex-column flex-grow-1">
<h2 class="TitoloMateria">Chimica</h2>
<div class="OpzioniMateria">
<button class="btn btn-primary BottoneElencaStudenti">
Elenco studenti
</button>
<button class="btn btn-primary BottoneElencaStudenti not-implemented">Elenco studenti</button>

<button class="btn btn-primary BottoneMostraLezioni">
Lezioni
</button>
<button class="btn btn-primary BottoneMostraLezioni not-implemented">Lezioni</button>
</div>

<div class="Registro flex-grow-1"></div>
Expand All @@ -80,7 +76,7 @@ <h3 class="Edita">edita</h3>

<ul class="Lista flex-grow-1">
<li class="Opzione">
<button class="EliminaRegistro">elimina registro</button>
<button class="EliminaRegistro not-implemented">elimina registro</button>
</li>
</ul>
</aside>
Expand Down
42 changes: 9 additions & 33 deletions view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,41 +5,17 @@ const notImplemented = () => {
alert("Not Implemented Yet");
}

// to grab all buttons just introduced in HTML with a `.not-implemented` class as default
const setupDefaultButtons = () => {
const allButtonsNonImplemented = document.querySelectorAll(".not-implemented");
allButtonsNonImplemented.forEach((elem) => {
elem.addEventListener("click", notImplemented);
})
}

// inserire le manipolazioni del dom qui dentro
document.addEventListener('DOMContentLoaded', function () {
var goToStudentsList = document.querySelector('.ElencoStudenti');
var goToLectures = document.querySelector('.BottoneMostraLezioni');
var deleteRegister = document.querySelector('.EliminaRegistro');

// FIXME : Attenzione a questi, le classi sono un bel po' confuse
var goToSubject = document.querySelectorAll('.TitoloMateria');
// var goToSubject2 = document.querySelector('.TitoloMateria .Chimica'); // NOTE : ne serve uno per ciascun bottone quando creato nel DOM


// NOTE : questo funzionava solo sul testo, ora sul div arrotondato. MAYBE deve essere rifinito
if (goToStudentsList) {
goToStudentsList.parentNode.parentNode.addEventListener('click', notImplemented);
}

if (goToLectures) {
goToLectures.addEventListener('click', notImplemented);
}

// NOTE : questo funzionava solo sul testo, ora sul div arrotondato. MAYBE deve essere rifinito
if (deleteRegister) {
deleteRegister.parentNode.addEventListener('click', notImplemented);
}

if (goToSubject) {
// FIXME : put a separated event listener to the button AddRegister
goToSubject.forEach(elem =>
elem.addEventListener('click', notImplemented)
);
}




setupDefaultButtons();
});


Expand Down