Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/attendants object CRUD #46

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat/attendants object CRUD #46

wants to merge 6 commits into from

Conversation

Rizaaal
Copy link
Collaborator

@Rizaaal Rizaaal commented Jan 20, 2024

This needs attention. As you may have noticed, the functions are not tied to the attendance object. I made it this way for 2 reasons:

  1. localStorage does not save object methods because they get stringified (JSON safe types)
  2. even if i wanted to, i could't figure it out how to add the method in a way that it finds its attendances list. This is becaus arrow functions don't have a this value, and even if i used a normal function i had to create the attendance using the keyword new, which is not how our program works.

So i had to create orrible functions such as getAttendance, where you have to put a register id to get a property that gets a property to get another property. yay!

So if you have a better way to do this, just feel free to give your input on this

@Rizaaal Rizaaal marked this pull request as ready for review January 20, 2024 14:34
@Rizaaal Rizaaal changed the title Feat/attendants crud attendants object CRUD Jan 20, 2024
@Rizaaal Rizaaal changed the title attendants object CRUD feat: attendants object CRUD Jan 20, 2024
@Rizaaal Rizaaal changed the title feat: attendants object CRUD Feat/attendants object CRUD Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant