refactor(webflux): introduce CommandMessageParser and remove CommandParser #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Ahoo-Wang
commented
Jan 9, 2025
Ahoo-Wang
commented
- Introduce new CommandMessageParser interface and DefaultCommandMessageParser implementation
- Remove static methods from CommandParser object
- Update related classes to use the new CommandMessageParser
- Rename CommandParserTest to DefaultCommandMessageParserTest
…arser - Introduce new CommandMessageParser interface and DefaultCommandMessageParser implementation - Remove static methods from CommandParser object - Update related classes to use the new CommandMessageParser - Rename CommandParserTest to DefaultCommandMessageParserTest
Test Results1 114 tests +2 1 094 ✅ - 1 10m 8s ⏱️ +34s For more details on these failures, see this check. Results for commit 41947be. ± Comparison against base commit fbd63fb. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.