Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(wow-core): update LocalFirstCommandBusTest to verify message content #1107

Merged
merged 1 commit into from
Jan 9, 2025
Merged

test(wow-core): update LocalFirstCommandBusTest to verify message content #1107

merged 1 commit into from
Jan 9, 2025

Conversation

Ahoo-Wang
Copy link
Owner

@Ahoo-Wang Ahoo-Wang commented Jan 9, 2025 •
edited
Loading

  • Replace verifyTimeout with more specific message content verification
  • Check if the received message ID and isVoid flag match the expected values
  • Update test to cancel subscription after receiving the expected message

@Ahoo-Wang
test(wow-core): update LocalFirstCommandBusTest to verify message con…
c0e7e6b 
…tent

- Replace verifyTimeout with more specific message content verification
- Check if the received message ID and isVoid flag match the expected values
- Update test to cancel subscription after receiving the expected message
@Ahoo-Wang Ahoo-Wang changed the title test(wow-core): update LocalFirstCommandBusTest to verify message content - Replace verifyTimeout with more specific message content verification - Check if the received message ID and isVoid flag match the expected values - Update test to cancel subscription after receiving the expected message test(wow-core): update LocalFirstCommandBusTest to verify message content Jan 9, 2025
@Ahoo-Wang Ahoo-Wang added the enhancement New feature or request label Jan 9, 2025
@Ahoo-Wang Ahoo-Wang merged commit fbd63fb into main Jan 9, 2025
46 checks passed
@Ahoo-Wang Ahoo-Wang deleted the LocalFirstCommandBusTest branch January 9, 2025 02:13
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (6d84e85) to head (c0e7e6b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #1107   +/-   ##
=========================================
  Coverage     89.00%   89.00%           
- Complexity     3113     3115    +2     
=========================================
  Files           641      641           
  Lines         11264    11266    +2     
  Branches        770      771    +1     
=========================================
+ Hits          10025    10027    +2     
  Misses          749      749           
  Partials        490      490
Flag Coverage Δ
unittests 89.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahoo-Wang