Conversation
|
PR naming should be like Hastebin: Use SSL URL @CharizardtheFireMage |
|
Side Note: If you are doing this
|
| if (!Formats[format]) return this.reply(this.trad('format') + " __" + format + "__ " + this.trad('notexists')); | ||
| this.reply(this.trad('download') + '... (' + link + ')'); | ||
| var http = require('http'); | ||
| var http = require('https'); |
There was a problem hiding this comment.
The variable http should be renamed to https (coz It looks kinda weird)
And change its references too obv
There was a problem hiding this comment.
That's truly unnecessary if https is defined
|
Note that this isn't main, @Lord-Haji, and that while clearer PR names are preferred, it's not as necessary since @CharizardtheFireMage provided a detailed commit description |
|
Thats sorta true @Mystifi |
|
apparently i made a duplicate pr to fix this. Imma bump this and close out mine. |
|
@CharizardtheFireMage I added your changes to my bot, and it worked as seen on http://replay.pokemonshowdown.com/exiled-gen7ou-800 thanks, hope you don't mind me adding these changes on my github and I plan to continue Ecuacion's bot work |
5 participants
Whenever I add a team with this bot, I check if the team copied into the bot's
teams.jsonbut whenever I view the JSON file, the team that I had uploaded into the bot's team database via.teams add, [name], [tier], [hastebin link]didn't copy the team at all. When I had a look between hastebin andfeatures-battle.js, I had found out that the file rather useshttpthanhttpsas hastebin is linked as [https://hastebin.com/]. Hence, why I am sending a pull request to fix this error in adding teams.