test: adding tests for setting up governance params for liquidation flow and ci changes #156
Conversation
rabi-siddique
force-pushed
the
rs-setting-governance-params
branch
3 times, most recently
from
f1796af to
075a93c
Compare
rabi-siddique
changed the title
rabi-siddique
force-pushed
the
rs-setting-governance-params
branch
from
075a93c to
060bede
Compare
| @@ -1 +1 @@ | |||
| import '@agoric/synpress/support/index'; | |||
There was a problem hiding this comment.
reason for changing this? index should work just fine
There was a problem hiding this comment.
I have customized the support.js file in @agoric/synpress. In the before hook, we originally set up the wallet. That sets the wallet every time I visit a different origin. I found this approach to be excessive, so I opted to override it. Now, I configure the wallet setup explicitly within a specific test to ensure we don't set the wallet everytime we visit a different origin.
There was a problem hiding this comment.
I was wondering if we should remove setting up wallet in the before hook?
| @@ -1,7 +1,8 @@ | |||
| /* eslint-disable ui-testing/no-disabled-tests */ | |||
| describe('Wallet App Test Cases', () => { | |||
| context('Test commands', () => { | |||
| it(`should connect with Agoric Chain`, () => { | |||
| it(`should setup wallet and connect with Agoric Chain`, () => { | |||
| cy.setupWallet(); | |||
There was a problem hiding this comment.
we dont have the SKIP_EXTENSION_SETUP flag enabled anywhere, wont this duplicate the setup of the wallet?
| entrypoint: [] | ||
| working_dir: /app | ||
| volumes: | ||
| - ./cypress/videos:/app/test/e2e/videos | ||
| - ./cypress/screenshots:/app/test/e2e/screenshots | ||
| command: > | ||
| bash -c 'echo -n "======> local noVNC URL: http://localhost:8080/vnc.html?autoconnect=true " && yarn wait-on http://display:8080 && echo -n "======> remote noVNC URL: " && curl -s ngrok:4040/api/tunnels | jq -r .tunnels[0].public_url && yarn test:e2e:ci' | ||
| bash -c 'echo -n "======> local noVNC URL: http://localhost:8080/vnc.html?autoconnect=true " && yarn wait-on http://display:8080 && echo -n "======> remote noVNC URL: " && curl -s ngrok:4040/api/tunnels | jq -r .tunnels[0].public_url && nginx && yarn test:e2e:ci' |
There was a problem hiding this comment.
This long line makes it hard to see changes. Consider a script with new lines
| it('should set up wallets for two members of the econ committee.', () => { | ||
| cy.setupWallet({ | ||
| secretWords: | ||
| 'such field health riot cost kitten silly tube flash wrap festival portion imitate this make question host bitter puppy wait area glide soldier knee', |
There was a problem hiding this comment.
Magic string. Please source from constants in a config module
|
|
||
| context('Adjusting Vault Params', () => { | ||
| it('should allow gov1 to create a proposal', () => { | ||
| cy.visit('https://econ-gov.inter.trade/?agoricNet=local'); |
The PR does the following:
This is the first PR for adding tests for implementing Happy Path Scanerio Liquidation. It will be followed by subsequent PRs containing other tests.