test: end-to-end bidding process testing

[rabi-siddique]

The PR does the following:

• Add test cases for placing bids from the CLI.
• Verify the existence of placed bids from the Wallet UI.
• Cancelling bids from the Wallet UI.
• Changes to ensure the CI pipeline doesn't break.

[turadg]

why is this building an SDK image? I'd expect it to use https://github.com/Agoric/agoric-sdk/pkgs/container/agoric-sdk ?

[rabi-siddique]

I wasn't aware of it. Using the SDK image has improved the CI time. It's been halved now. Thanks for sharing!

But bidding-specific test cases are failing now for some reason. I am inspecting the issue and will get back to you once done with finding the root cause.

[rabi-siddique]

@turadg, I was investigating the issue and discovered that it's related to a discrepancy in node versions.
The agoric-sdk image is configured with node 18.20and presently, our tests run smoothly with node version 18.18. I was able to replicate the failing test cases in our CI environment by upgrading my local node version to 18.20.

It's more so of an issue with cypress because inside the container I was successfully able to place bids from the shell.
I was trying to update cypress version for @agoric/synpress and make it compatible with node 18.20. But I feel it needs to be done carefully to avoid breaking other things.

Do you have any suggestions? Can we override the node version in agoric-sdk image?

[rabi-siddique]

@turadg Finally working. I've used nvm to install node 18.18. When I run tests, I switch to node 18.18 with nvm use and it works.

[turadg]

ok, if the tests require 18.18 to run please,

• add a .node-version file that some Node version managers will observe automatically (I use nodenv which does)
• file an issue on the repo to remove that restriction (it may just require updating ses and @endo` deps to latest)
• point to that issue in all code used to pin the Node version

But it would be much better for @agoric/synpress to be compatible with 18.20. What is failing? I don't see anything in the Cypress repro about that Node version incompatibility. Some earlier version of ses failed on a change in 18.19. Maybe the problems can be solved by bumping other deps.

Let's figure out what part of the stack is broken in 18.20 before hacking so much around it here

[rabi-siddique]

@turadg I think ses version is not an issue. I tried different versions and it gave no issues until I switched to node 18.20.

I also tried bumping versions of cypress and typescript. But they work fine till I use node 18.20. The issue doesn't exist for node versions up to 18.18. For versions beyond 18.18, excluding 20.4, the majority exhibit this issue.

The issue is the following error when trying to place bids with the agops command:

Removing intrinsics.Symbol.dispose
failed to delete intrinsics.Symbol.dispose (TypeError#1)
TypeError#1: Cannot delete property 'dispose' of function Symbol() { [native code] }

(TypeError#1)

I came across it over here as well:
Agoric/agoric-sdk#8599

[turadg]

Thanks for the diligence in chasing the SES / Node error

[turadg]

consider using Node.js scripts instead. Especially for tests. LTS has a built-in test runner https://nodejs.org/docs/latest-v20.x/api/test.html. Shell commands can run with https://nodejs.org/docs/latest-v20.x/api/child_process.html#child_processexecsynccommand-options. It even has JSON parsing ;-)

[rabi-siddique]

Thanks for the diligence in chasing the SES / Node error

@turadg Thanks for pushing me to find the root cause of the problem :)