chore: upgrade ses version #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
cd7454b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a0adb95b.wallet-app.pages.dev |
| Branch Preview URL: | https://upgrade-ses.wallet-app.pages.dev |
turadg
approved these changes
Feb 27, 2024
LuqiPan
reviewed
Feb 27, 2024
| @@ -86,7 +86,7 @@ | |||
| "analyze": "source-map-explorer 'build/static/js/*.js'", | |||
| "start": "yarn build:ses && react-app-rewired start", | |||
| "build": "yarn build:ses && yarn build:react", | |||
| "build:ses": "cp node_modules/ses/dist/lockdown.umd.js public/", | |||
| "build:ses": "cp ../node_modules/ses/dist/lockdown.umd.js public/", | |||
There was a problem hiding this comment.
question
Just curious, is this script still needed?
There was a problem hiding this comment.
Yea, the wallet-app is structured differently from the other apps, and does lockdown in index.html https://github.com/Agoric/wallet-app/blob/main/wallet/public/index.html#L5-L21
IIRC it was done so that the bundler would not transform lockdown.umd.js, which was causing issues at the time. The newer apps that use vite don't have this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #140