Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node selectors to connection settings #134

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

samsiegart
Copy link
Contributor

fixes #130

Adds auto-suggest inputs for rpc and api nodes. The suggestions are fetched from the currently selected network config. When the inputs are empty, it just defaults to a random node, so the inputs are not required.

Screenshot

image

Copy link

cloudflare-workers-and-pages bot commented Jan 19, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4762560
Status: ✅  Deploy successful!
Preview URL: https://21a47295.wallet-app.pages.dev
Branch Preview URL: https://node-selector.wallet-app.pages.dev

View logs

Copy link
Member

@0xpatrickdev 0xpatrickdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changing Localhost API URL seems to throw
  • “Testnet” is not mapping to anything - should this be Emerynet?
  • Localhost uses origin instead of localhost - is this intentional?
Screen.Recording.2024-01-19.at.12.50.35.PM.mov

@samsiegart
Copy link
Contributor Author

samsiegart commented Jan 19, 2024

Changing Localhost API URL seems to throw

Fixed, it was throwing if apiAddrs (or rpcAddrs) was missing from the network config.

“Testnet” is not mapping to anything - should this be Emerynet?

Yea I think we used to have a "testnet" but not anymore, seems sensible to change to emerynet, just did.

Localhost uses origin instead of localhost - is this intentional?

Yea, the wallet app itself has a network config so you can edit it if you're running the UI locally, I just changed it to "Local" instead of "Localhost" though so it's not as potentially misleading. The "Localhost" I think implied that your chain was running on localhost, not the network config.

@samsiegart samsiegart merged commit 009f5ea into main Jan 19, 2024
2 checks passed
@samsiegart samsiegart deleted the node-selector branch January 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RPC node selector (Wallet UI)
2 participants