Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy react components #88

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Deploy react components #88

merged 2 commits into from
Feb 29, 2024

Conversation

samsiegart
Copy link
Contributor

Failing deployment: https://github.com/Agoric/ui-kit/actions/runs/8092461024/job/22113217987

Apparently this means we need to set:

  "publishConfig": {
    "access": "public"
  }

...like the other packages. Setting "private": false is not enough.

Also fixed the non-fatal error:

Error: src/lib/config/index.ts(42,14): error TS2742: The inferred type of 'makeAssetList' cannot be named without a reference to 'chain-registry/node_modules/@chain-registry/types'. This is likely not portable. A type annotation is necessary.

@samsiegart samsiegart requested a review from turadg February 29, 2024 08:23
@samsiegart samsiegart merged commit 585b47d into main Feb 29, 2024
1 check passed
@samsiegart samsiegart deleted the deploy-react-components branch February 29, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants