Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Monitoring follower #119

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

usmanmani1122
Copy link

Description

This PR adds a monitoring follower (which is just the runner code copied with loadgen code commented out)
Also adds a support for stopping the follower using MESSAGE_FILE_PATH messages

@usmanmani1122 usmanmani1122 self-assigned this Jan 8, 2025
Copy link

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usmanmani1122
Can you point to the file(s) having actual changes and where loadgen code is removed?

For example one of them is: tasks/testnet.js where usage of makeLoadgenTask is removed.

Also let's have a follow-up issue/task to actually clean this up and remove redundant unused code.

Copy link

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also expose monitor in package.json scripts just like we have for loadgen and runner?

"runner": "runner/bin/loadgen-runner",
    "loadgen": "agoric deploy loadgen/loop.js"
    "monitor": ...

@usmanmani1122
Copy link
Author

Do we need to also expose monitor in package.json scripts just like we have for loadgen and runner?

"runner": "runner/bin/loadgen-runner",
    "loadgen": "agoric deploy loadgen/loop.js"
    "monitor": ...

No, since monitor uses yarn version 4.3.5 (opposed to 1.22.xx in root workspace)

@usmanmani1122
Copy link
Author

@usmanmani1122 Can you point to the file(s) having actual changes and where loadgen code is removed?

For example one of them is: tasks/testnet.js where usage of makeLoadgenTask is removed.

Also let's have a follow-up issue/task to actually clean this up and remove redundant unused code.

Only monitor/src/main.js and monitor/src/tasks/testnet.js have any changes
Rest of the files are copied
Changes outside the monitor folder were made in an attempt to pass the CI but it is still failing and I think the CI tests won't pass without making changes in the CI pipeline
@muhammadahmadasifbhatti can you make the follow up task (or add the link here if already created)?

@muhammadahmadasifbhatti

@usmanmani1122 Can you point to the file(s) having actual changes and where loadgen code is removed?
For example one of them is: tasks/testnet.js where usage of makeLoadgenTask is removed.
Also let's have a follow-up issue/task to actually clean this up and remove redundant unused code.

Only monitor/src/main.js and monitor/src/tasks/testnet.js have any changes Rest of the files are copied Changes outside the monitor folder were made in an attempt to pass the CI but it is still failing and I think the CI tests won't pass without making changes in the CI pipeline @muhammadahmadasifbhatti can you make the follow up task (or add the link here if already created)?

I will create a task and add the link here. Can you please provide me with the JIRA project link?

@usmanmani1122
Copy link
Author

I will create a task and add the link here. Can you please provide me with the JIRA project link?

Use github issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants