-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Monitoring follower #119
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@usmanmani1122
Can you point to the file(s) having actual changes and where loadgen code is removed?
For example one of them is: tasks/testnet.js
where usage of makeLoadgenTask
is removed.
Also let's have a follow-up issue/task to actually clean this up and remove redundant unused code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to also expose monitor
in package.json scripts just like we have for loadgen and runner?
"runner": "runner/bin/loadgen-runner",
"loadgen": "agoric deploy loadgen/loop.js"
"monitor": ...
No, since monitor uses yarn version |
Only |
I will create a task and add the link here. Can you please provide me with the JIRA project link? |
Use github issues |
Description
This PR adds a monitoring follower (which is just the runner code copied with loadgen code commented out)
Also adds a support for stopping the follower using
MESSAGE_FILE_PATH
messages