Check for Blocks before Contract Start and Adding Format Script #108
Conversation
amessbee
force-pushed
the
ms/check-chain-status-before-contract-start
branch
from
aecdd7c to
e8a1e17
Compare
amessbee
force-pushed
the
ms/check-chain-status-before-contract-start
branch
from
e8a1e17 to
e5904f6
Compare
.gitignore
Outdated
| @@ -39,3 +39,4 @@ videos | |||
|
|
|||
| # contract tx | |||
| contract/,tx.json | |||
| contract/start-offer-up-plan.json | |||
There was a problem hiding this comment.
drive-by? put it in a separate commit, perhaps?
There was a problem hiding this comment.
Yes :) - sure, will do.
contract/scripts/wait-for-chain.sh
Outdated
| local required_patterns=3 # Number of block patterns we want to see | ||
|
|
||
| while IFS= read -r line; do | ||
| echo "$line" # Show the log output |
There was a problem hiding this comment.
consider showing just 1 dot (.) instead
| if [[ $line =~ "block-manager: block "[0-9]+" commit" ]]; then | ||
| ((count++)) | ||
| if [ $count -ge $required_patterns ]; then | ||
| return 0 # Success |
There was a problem hiding this comment.
perhaps show the whole line at this point; i.e. give evidence in the form of a timestamp and block number that things are running.
There was a problem hiding this comment.
so rather than 150 lines of agd output in the ci log we would see...
Run yarn start:contract
Waiting for blockchain to start........(~150 dots)...
agd-1 | 2025-01-08T08:20:28.543Z block-manager: block 1227 commit
Blockchain is running and producing blocks...
Co-authored-by: Dan Connolly <[email protected]>
amessbee
force-pushed
the
ms/check-chain-status-before-contract-start
branch
from
15c610a to
60b9b18
Compare
|
yay! much nicer DX! -- ci log |
| echo "Blockchain is running and producing blocks..." | ||
| exit 0 | ||
| else | ||
| echo "Failed to detect blockchain activity\n Run yarn start:docker to start the blockchain first!" |
There was a problem hiding this comment.
oops... I should have checked this part; it doesn't seem to work for me. If I do yarn start:contract before yarn start:docker, I get:
$ yarn start:contract
Waiting for blockchain to start...
............
agd-1 | 2024-12-13T14:50:03.351Z block-manager: block 44932 commit
Blockchain is running and producing blocks...
service "agd" is not running
maybe that won't affect 1st time users
perhaps it's because I have stuff in my docker logs from an earlier run
There was a problem hiding this comment.
Seems to work fine for me:
Waiting for blockchain to start...
Failed to detect blockchain activity\n Run yarn start:docker to start the blockchain first!
Although newline character is not treated as such due to missing -e I suppose. If I am going create a PR just for -e, I am going treat myself with red color added to the above line too.
potentially closes: #27