chore: adjusting e2e test cases with a3p:latest #270
Conversation
test/e2e/specs/test.spec.js
Outdated
| cy.acceptAccess().then(taskCompleted => { | ||
| it('should set up wallet', () => { | ||
| cy.setupWallet({ | ||
| secretWords: |
There was a problem hiding this comment.
magic string belong in a config file. I suspect it can be imported from @agoric/synthetic-chain
There was a problem hiding this comment.
We're not using @agoric/synthetic-chain in dapp-inter. Perhaps we should source it from config.ts like this:
https://github.com/Agoric/dapp-inter/compare/2f0e475855c1964c9aed27add8efb84ebb5e944a..4b1abf088164dce0fa06d0edb41486ff590cc2a9
There was a problem hiding this comment.
That's an improvement. However, it's called a "mnemonic" and the name suggests there's only one. Consider leaving room for more accounts,
```suggestion
export const mnemonics = {
user1: 'tackle hen gap lady bike explain erode midnight marriage wide upset culture model select dial trial swim wood step scan intact what card symptom';
}
though I'd be fine punting this to use exports from the synthetic-chain lib. If you opt for that, please leave an UNTIL https://github.com/Agoric/agoric-3-proposals/issues/154 comment.
test/e2e/specs/test.spec.js
Outdated
| cy.contains('Connect Wallet').click(); | ||
| cy.get('label.cursor-pointer input[type="checkbox"]').check(); | ||
| cy.contains('Proceed').click(); | ||
| cy.contains('.input-label', 'ATOM to lock up *') |
There was a problem hiding this comment.
can't this be selected without depending on the class?
There was a problem hiding this comment.
@turadg Updated
The PR:
image: ghcr.io/agoric/agoric-3-proposals:mainwithimage: ghcr.io/agoric/agoric-3-proposals:latestimage: ghcr.io/agoric/agoric-3-proposals:latest