ci(dependency-graph): remove packing artifacts from cache #9413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
added
tooling
michaelfig
force-pushed
the
mfig-no-cache-packing-artifacts
branch
from
0cf6918 to
470dc01
Compare
Deploying agoric-sdk with
|
| Latest commit: |
9878b43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ea9a816b.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-no-cache-packing-artifa.agoric-sdk.pages.dev |
turadg
approved these changes
May 27, 2024
| # Don't put the prepack artifacts in the cache maintained by restore-node, | ||
| # since they are not .gitignored and thus will fail restore-node's check | ||
| # for a clean repo when the cache is restored. | ||
| - name: Prevent caching prepack artifacts |
There was a problem hiding this comment.
I think this run could be under the same name. It's not relevant to someone reading the logs.
The comment is helpful for understanding what the step does and why.
michaelfig
requested review from
turadg and
mhofman
and removed request for
mhofman
michaelfig
force-pushed
the
mfig-no-cache-packing-artifacts
branch
from
470dc01 to
250c6ec
Compare
|
The Docker test may be failing because the upstream advanced in Agoric/agoric-3-proposals#157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9412
Description
Take option 1 described in #9412's "Additional Context" and run the
postpackjob to clean up artifacts generated by the explicitprepackin thedependency-graphjob.Testing Considerations
Tested on every CI run.