Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump tsx #9006

Closed
wants to merge 5 commits into from
Closed

bump tsx #9006

wants to merge 5 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Feb 28, 2024

no ticket

Description

https://github.com/privatenumber/tsx/releases

Bumps node engine for the boot package go 18.19 to get consistent --import flag behavior. Safe because it's test only.

@warner this also includes some cleanup to the benchmark package which is why I wanted your review.

Security Considerations

n/a, test only

Scaling Considerations

n/a, test only

Documentation Considerations

n/a, test only

Testing Considerations

  • no slower

Upgrade Considerations

n/a, test only

@turadg turadg changed the title bump Ava to 5.3.1 bump tsx Mar 13, 2024
@turadg turadg force-pushed the ta/bump-ava-5.3.1 branch from 54cdf9c to 40ed281 Compare March 19, 2024 16:27
@turadg turadg force-pushed the ta/bump-ava-5.3.1 branch from 40ed281 to a9a8d3a Compare March 26, 2024 16:37
@turadg turadg requested review from warner and iomekam March 26, 2024 16:40
@turadg turadg marked this pull request as ready for review March 26, 2024 16:40
Copy link
Contributor

@iomekam iomekam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Apr 2, 2024
@turadg turadg force-pushed the ta/bump-ava-5.3.1 branch from 516d376 to 9f3992c Compare April 2, 2024 22:17
Copy link

github-actions bot commented Apr 4, 2024

@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours

@turadg turadg force-pushed the ta/bump-ava-5.3.1 branch from 9f3992c to 1aa9839 Compare April 4, 2024 13:36
Copy link

github-actions bot commented Apr 6, 2024

@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours

@turadg turadg marked this pull request as draft April 6, 2024 14:12
@turadg
Copy link
Member Author

turadg commented Apr 6, 2024

Copy link

github-actions bot commented Apr 8, 2024

@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours

1 similar comment
Copy link

github-actions bot commented Apr 9, 2024

@turadg - This PR appears to be stuck. It's had a merge label for > 24 hours

@turadg turadg removed the automerge:rebase Automatically rebase updates, then merge label Apr 9, 2024
@turadg
Copy link
Member Author

turadg commented Dec 17, 2024

we dropped this dep

@turadg turadg closed this Dec 17, 2024
@turadg turadg deleted the ta/bump-ava-5.3.1 branch December 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants