Re-add a CoreEval proposal to a3p-integration #8907
Conversation
| #!/bin/bash | ||
| set -ueo pipefail | ||
|
|
||
| sdkroot=$(cd -- "$(dirname "$0")/.." >/dev/null && pwd) |
There was a problem hiding this comment.
doesn't this have the same issue as motivated you to revert the previous? people can also forget to update this script. moreover, if they do manually update the submission, this will overwrite it.
however, this is (as was the previous commit imo) better than the status quo so I approve.
There was a problem hiding this comment.
doesn't this have the same issue as motivated you to revert the previous? people can also forget to update this script.
The problem in the previous attempt was that the submission would get out of sync with the code in the repo. Here the submission is re-generated every time a3p-integration builds.
Yes adding or changing the shape of new a3p proposal requires to update this script, but that's much less frequent.
moreover, if they do manually update the submission, this will overwrite it.
The submission is git excluded. If the submission needs editing for some reason, it should be automated in the script that generates it.
Re-add a CoreEval proposal to a3p-integration
Re-add a CoreEval proposal to a3p-integration
Re-add a CoreEval proposal to a3p-integration
refs: #8801
Description
Re-lands f864dd3 which was reverted in #8905, but with the submission automatically generated instead of being checked in.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
Code example of a3p core eval proposal
Testing Considerations
None
Upgrade Considerations
This is to simulate a core eval that would happen independently of an upgrade, but still generated from the agoric-sdk release