feat: doctor checks for "set -e" in test scripts #207
Conversation
| @@ -2145,6 +2164,22 @@ __metadata: | |||
| languageName: node | |||
| linkType: hard | |||
|
|
|||
| "glob@npm:^11.0.0": | |||
There was a problem hiding this comment.
I'm surprised we don't already have a glob dep...
oh... this is in agoric-3-proposals.
In agoric-sdk, we have a menagerie:
$ grep 'glob ' yarn.lock
glob "8.0.3"
glob "8.0.3"
glob "8.0.3"
glob "^8.0.1"
glob "^7.1.6"
is-glob "^4.0.3"
glob "^7.1.6"
fast-glob "^3.3.2"
is-glob "^4.0.3"
glob "^8.0.1"
glob "^10.2.2"
is-glob "~4.0.1"
is-glob "^4.0.3"
is-glob "^4.0.0"
is-glob "^4.0.1"
is-glob "^4.0.3"
dir-glob "^3.0.1"
fast-glob "^3.2.9"
dir-glob "^3.0.1"
fast-glob "^3.2.11"
is-glob "^4.0.1"
is-extglob "^2.1.1"
glob "^7.1.4"
glob "^8.0.1"
fast-glob "3.2.7"
glob "7.1.4"
glob "^8.0.1"
glob "^7.1.3"
glob "^10.0.0"
glob "^7.1.3"
glob "^10.3.7"
glob "^7.0.0"
glob "^7.1.4"
glob "^10.4.1"
fast-glob "3"
proposals/29:upgrade-9/test.sh
Outdated
| @@ -1,4 +1,5 @@ | |||
| #!/bin/bash | |||
| set -e | |||
There was a problem hiding this comment.
docs say...
"set -euo pipefail" is recommended.
you didn't want to risk compat problems?
There was a problem hiding this comment.
yeah, but I should follow the advice. updated.
There was a problem hiding this comment.
I had to revert it to get to green. Something for another time.
| @@ -8,6 +8,7 @@ and then fulfill the remaining checklist items before merging. | |||
| Closes # | |||
|
|
|||
| # adopt a passed proposal | |||
|
|
|||
There was a problem hiding this comment.
is the prettier style set up to stick?
or was this just a 1-time?
There was a problem hiding this comment.
thanks for inquiring. It's one time and I didn't know why CI hadn't errored on it. Looks like --write makes --check only warn because it's updating: https://github.com/Agoric/agoric-3-proposals/actions/runs/12125081638/job/33804228478
I'll fix it
some deps had incompatible defs Error: ../../node_modules/@types/glob/index.d.ts(29,42): error TS2694: Namespace '"/home/runner/work/agoric-3-proposals/agoric-3-proposals/node_modules/minimatch/dist/cjs/index"' has no exported member 'IOptions'.
solves package export map for cosmic-proto
This reverts commit 222c7d8.
This reverts commit 895c00a.
Closes #206
tooling improvements
I also tested locally with,
yarn buildin the packageThat led to errors in many test.sh files so I cleaned those up.
I tried adopting the
-eacross all scripts but CI failed and I had to revert. We'll have them going forward.