fix: --recover to get mnemonic from file #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanlei suggests a test that the generated address is as expected. Seems reasonable. hm. |
|
Thank you for fixing my mistakes Re: CI failure, I made another mistake and copied the same mnemonics for gov3, user1, and validator I can push some commits to fix it if you want |
turadg
approved these changes
Apr 2, 2024
dckc
commented
Apr 2, 2024
turadg
reviewed
Apr 2, 2024
proposals/16:upgrade-8/use.sh
Outdated
| @@ -5,6 +5,8 @@ set -e | |||
|
|
|||
| source /usr/src/upgrade-test-scripts/env_setup.sh | |||
|
|
|||
| yarn ava keys.test.js | |||
There was a problem hiding this comment.
is this just debugging? tests don't belong in use.sh. the ones here are tech debt
There was a problem hiding this comment.
Yeah I noticed keys.test.js was not run and found an example of running it in use.sh
I've since moved it to test.sh
... to more accurately reflect the test cases in it
dckc
commented
Apr 2, 2024
| @@ -4,7 +4,7 @@ set -e | |||
|
|
|||
| source /usr/src/upgrade-test-scripts/env_setup.sh | |||
|
|
|||
| yarn ava addresses.test.js | |||
| YARN_IGNORE_NODE=1 yarn ava addresses.test.js | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe this is all it takes?
fixes: #136
cc @ivanlei