test: add auction double closure regression#351
Merged
Yunusabdul38 merged 2 commits intoAgora-Events:mainfrom Mar 29, 2026
Merged
Conversation
|
@David-patrick-chuks is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@David-patrick-chuks Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@David-patrick-chuks fix ci error |
Contributor
Author
|
@Yunusabdul38 FIXED |
Yunusabdul38
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR verifies the auction double-finalization guard in
close_auctionand adds regression coverage to ensure an auction cannot be closed more than once. The new test exercises a successful auction close followed by a second close attempt, which must be rejected.Related Issue
Closes #212
Changes
⚙️ Auction Finalization Guard
contract/contracts/ticket_payment/src/contract.rsclose_auctionchecksis_auction_closedbefore finalizing the auction.TicketPaymentError::AuctionEnded.🧪 Unit Tests
contract/contracts/ticket_payment/src/test.rstest_close_auction_rejects_double_closure.Verification Results
close_auctionprevents double finalizationcargo testpassescargo clippy --all-targets --all-features -- -D warningspassesHow to Test