feat(contract): standardize event name trimming (#326)#350
Open
Chibey-max wants to merge 1 commit intoAgora-Events:mainfrom
Open
feat(contract): standardize event name trimming (#326)#350Chibey-max wants to merge 1 commit intoAgora-Events:mainfrom
Chibey-max wants to merge 1 commit intoAgora-Events:mainfrom
Conversation
- Add `name` field to `EventRegistrationArgs` and `EventInfo` structs - Implement `trim_string` helper to strip leading/trailing ASCII whitespace - Apply trimming to event name in `register_event` before persisting - Add `name` field to local `EventInfo` copy in ticket_payment contract - Add `test_register_event_name_trimming` test with intentionally messy names - Update all existing test fixtures to include the new `name` field
|
@Chibey-max is attempting to deploy a commit to the oseh-svg's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Chibey-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Chibey-max fix failling ci check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #326
Ensures event names are cleanly stored by trimming leading and trailing whitespace during registration to prevent UI inconsistencies.
Changes
Test
```
test test::test_register_event_name_trimming ... ok
test result: ok. 142 passed; 0 failed
```" \