security: stamp SchemaVersion at init to distinguish fresh v2 deploys - #52
Merged
mikewheeleer merged 1 commit intoJun 24, 2026
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jagadeeshftw
force-pushed
the
security/contracts-init-stamps-schema-version
branch
from
June 24, 2026 02:26
60f70e8 to
616ea63
Compare
Contributor
|
smart — stamping SchemaVersion at init removes the pre-migration ambiguity. merging 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initnow stamps the current storage schema version (CURRENT_SCHEMA = 2) intoDataKey::SchemaVersion. A freshly deployed contract reportsget_schema_version() == 2without ever running a migration, while legacy v1 deployments still carry the implicit v1 default (get_schema_version'sunwrap_or(1)is unchanged) and must runmigrate_v1_to_v2(). Running that migration on a fresh v2 deploy correctly panics withMigrationVersionMismatch.Closes #44
Test output
Security notes
Stamping the schema version at init removes the ambiguity between a fresh v2 deploy and an un-migrated v1 state, preventing an accidental migration re-run from silently mutating a current-schema contract.