security: reject self-targeted proposals in propose_admin_transfer - #50
Merged
mikewheeleer merged 1 commit intoJun 24, 2026
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Jagadeeshftw
force-pushed
the
security/contracts-admin-proposal-validation
branch
from
June 24, 2026 02:25
29ea093 to
0be5d3d
Compare
Contributor
|
good hardening on propose_admin_transfer. merging 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens
propose_admin_transferto reject proposing the current admin as the new admin. Afteradmin.require_auth(), the call now panics with the new append-only errorInvalidAdminProposal = 13whennew_admin == admin, surfacing no-op handovers as caller mistakes.Closes #43
Test output
Security notes
Prevents a no-op admin proposal from masking a misconfigured handover; the validation runs only after admin auth, so it cannot be triggered by unauthorised callers.