fix: chain asyncio.TimeoutError cause in _call_with_timeout#114
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix: chain asyncio.TimeoutError cause in _call_with_timeout#114andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
Both coding_loop.py and dag_executor.py define _call_with_timeout and catch asyncio.TimeoutError, but they raised a plain TimeoutError without chaining the original exception. Preserve the cause so callers can trace the timeout back to its source. Adds a parametrized unit test that asserts TimeoutError.__cause__ is the original asyncio.TimeoutError for both implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
_call_with_timeoutin bothcoding_loop.pyanddag_executor.pycaughtasyncio.TimeoutErrorand raised a plainTimeoutError, dropping the original exception chain.Fix
Use
raise ... from excin both implementations soTimeoutError.__cause__carries the originalasyncio.TimeoutError.Test
Added
tests/test_call_with_timeout.pywith a parametrized async test that asserts the cause is chained for both implementations.Verification
AGENTFIELD_SERVER=http://localhost:9999 pytest tests/test_call_with_timeout.py -vpasses (2 tests).