Add Google ADK support to runner pattern #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement GoogleADKRunner class extending BaseAgentRunner - Add support for Google Agent Development Kit (ADK) integration - Include both run() and run_streamed() methods with event forwarding - Add conditional imports to make google-adk an optional dependency - Create example usage file demonstrating GoogleADKRunner The runner follows the same pattern as OpenAIRunner and provides: - Automatic activity tracking - Session management with InMemorySessionService - Streaming support with async event forwarding - Integration with runner.tools.report_status for progress tracking
Updated implementation to properly use Google ADK's built-in features: - Replace max_turns with RunConfig (ADK's execution control mechanism) - Use max_llm_calls parameter (default 500) instead of max_turns - Remove max_turns_recovery logic (not applicable to ADK) - Pass run_config parameter through to runner.run_async() - Defer to ADK's internal execution control - Update example to demonstrate RunConfig usage - Simplify API to match ADK conventions ADK uses RunConfig for runtime behavior control including: - max_llm_calls: safeguard against runaway loops - streaming_mode: control streaming behavior - support_cfc: function calling configuration This aligns with ADK best practices and reduces unnecessary abstraction layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runner follows the same pattern as OpenAIRunner and provides: