fix(api): resolve dependency conflicts blocking Backend CI and E2E - #247
Open
Dev-Odun-oss wants to merge 1 commit into
Open
fix(api): resolve dependency conflicts blocking Backend CI and E2E#247Dev-Odun-oss wants to merge 1 commit into
Dev-Odun-oss wants to merge 1 commit into
Conversation
- pin @nestjs/swagger to ^8.1.1 (was ^11.4.5, which requires Nest 11 while the app runs Nest 10 — caused npm ci ERESOLVE failures in Backend CI and E2E). Verified the swagger decorators used in this codebase (ApiTags/ApiOperation/ApiResponse/ApiBearerAuth/ApiQuery/ ApiProperty/ApiHeader) are unchanged across v8. - add missing nestjs-pino and pino-pretty deps, imported by src/app.module.ts but never declared in package.json, which broke compilation for any test run. Both issues are reproducible identically on main. Backend/E2E CI still has separate, unrelated pre-existing failures (repo-wide lint debt, a Prisma field mismatch in audit.service.ts, and a frontend vitest/jsdom incompatibility) that are tracked separately and out of scope here. closes Afro-Pay#246 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Dev-Odun-oss is attempting to deploy a commit to the milah's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246.
Problem
npm ciinapps/apifails on every fresh install with anERESOLVEerror:@nestjs/swagger@^11.4.5requires@nestjs/common@^11.0.1, but the rest of the app pins Nest to^10.0.0. This blocks the Backend CI (API) and E2E Tests jobs before a single test runs — reproducible identically onmain, unrelated to any specific feature branch.Once that's unblocked, the app also fails to compile:
src/app.module.tsimportsLoggerModulefromnestjs-pino(with apino-prettytransport), but neither package is declared inpackage.json.Changes
apps/api/package.json: pin@nestjs/swaggerto^8.1.1(last major compatible with Nest 10's peer range^9.0.0 || ^10.0.0). Checked every swagger API used in this codebase (ApiTags,ApiOperation,ApiResponse,ApiBearerAuth,ApiQuery,ApiHeader,ApiProperty,ApiPropertyOptional) — all unchanged across v8.nestjs-pinoandpino-prettyas direct dependencies.package-lock.json.Verification
npm cinow succeeds with noERESOLVEerrorsnpm run prisma:generatesucceedsnpm run test: 103 tests passing across 12/18 suites (up from a hard install failure onmaintoday — before this fix,npm cinever even completed)Out of scope (tracked separately, unrelated to this fix)
audit.service.tsthat blocks E2E test compilationvitest/jsdom/undiciversion incompatibility breaking accessibility testsVercelcheck, which fails only on "Authorization required to deploy" (an org/project setting, not a code issue)🤖 Generated with Claude Code