AssocFn with vtable_receiver #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
reviewed
Sep 29, 2025
Nadrieril
reviewed
Sep 29, 2025
Nadrieril
reviewed
Sep 29, 2025
Member
|
Btw you may have guessed but you can entirely ignore CI failures in this repo: this is trying to run the same tests as upstream hax but I only care about what affects charon. |
Author
|
Sure, thanks! |
Author
|
Mentioned issues all resolved. |
Nadrieril
reviewed
Oct 2, 2025
Nadrieril
reviewed
Oct 2, 2025
Nadrieril
reviewed
Oct 2, 2025
Member
|
Looks good, ty! |
Member
|
This is causing lots of panics, did you test this in charon before submitting it? We should not have merged it if it breaks charon. |
Member
|
Found a fix. |
Author
|
The original version (before the is_vtable_safe_method) works well with the PR AeneasVerif/charon#814 . But the later versions are not tested. I’m away from the office now. |
Member
|
It was indeed an incorrect invocation of |
Author
|
Sorry about that and thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to work with AeneasVerif/charon#814 . With the
vtable_safe(bool) changed tovtable_receiver(Option<Ty>), theVtableMethodis now free from theTyparameters.