-
Notifications
You must be signed in to change notification settings - Fork 26
Dyn method dispatch #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dyn method dispatch #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3917c3e to
5c500f6
Compare
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
charon/src/bin/charon-driver/translate/translate_trait_objects.rs
Outdated
Show resolved
Hide resolved
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
Nadrieril
reviewed
Oct 8, 2025
6a7e238 to
81edea2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #814 , this PR is further split from #762, which includes the part of vtable support for the correct dispatch of virtual methods. Now, calling methods of &dyn Trait will be translated to finding the corresponding function pointer from the vtable (fetched by ptr_metadata operation) and then call the function pointer.
Specifically, calling virtual methods is turned from
<dyn Trait as Trait>::method(receiver, args...)to something like:This is reached by adding a new pass:
normalize::transform_dyn_trait_calls.