Repository navigation
Fix kasa exporter - #5
Merged
Merged
Conversation
Add `tzdata` package to Docker dependencies and implement a timezone compatibility fix for Kasa devices that report POSIX timezone strings (e.g., PST8PDT). Python's zoneinfo fails when tzdata is incomplete in Docker environments, causing ZoneInfoNotFoundError exceptions. The new `_patch_timezone_lookup()` function wraps kasa's CachedZoneInfo to gracefully fall back to UTC when a timezone cannot be resolved, with appropriate debug logging for visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bug Fixes
PST8PDT) that Python'szoneinfocannot resolve whentzdatais incomplete in Docker containers, causingZoneInfoNotFoundErrorcrashes. Added_patch_timezone_lookup()to gracefully fall back to UTC with debug logging. Installedtzdatapackage in the Docker image.Code Quality
kasa-exporter.pytokasa_exporter.py- Proper Python snake_case naming convention compliance._poll_device_once()- Extracted outlet processing into a dedicated_process_outlet()helper, reducing local variable count from 16 to under pylint's threshold.device_cfgtodev_configinpoll_device()- Eliminates variable shadowing of the module-level config reference (redefined-outer-name)..pylintrc- Documents and suppresses only intentionally-accepted warnings (broad exception catches for device I/O resilience, protected access for kasa internals patching, lazy imports).New Features
INFO-level log on successful poll andDEBUG-level log before each connection attempt, enabling visibility into exporter liveness via Docker logs.