-
Notifications
You must be signed in to change notification settings - Fork 82
Code generation: update services and models #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request represents an automated update to the codebase, reflecting recent modifications in the OpenAPI specifications. The primary goal is to keep the generated service clients and data models in sync with the latest API definitions. Key changes include the introduction of standardized error handling types across various services, updates to specific type definitions, and adjustments to polymorphic deserialization logic in certain models.
Highlights
- Automated Code Regeneration: This pull request is an automated update to service clients and model definitions, reflecting recent modifications in the OpenAPI specifications.
- Standardized Error Handling: New error types, specifically
RestServiceError
andServiceError
, have been introduced and imported across numerous service files to standardize error response handling. - Type Definition Updates: Several type definitions have been updated, including the addition of
ResourceType
in session authentication models andSettingType
/Target
in balance platform webhook models. - Discriminator Mapping Adjustment: The
TransferDataTracking
model's discriminator mapping has been modified, removing explicit type mapping for polymorphic deserialization. - Code Style Consistency: Minor stylistic changes were applied, such as converting double quotes to single quotes for string literals in function parameters across various API methods.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates generated services and models. Most changes involve adding imports for error types and minor stylistic adjustments. However, I've found a critical issue in src/typings/transferWebhooks/transferDataTracking.ts
where a mapping
for a discriminator is removed. This is very likely to break deserialization of polymorphic types at runtime. I've provided a specific comment and a code suggestion to fix it.
static readonly discriminator: string = "type"; | ||
|
||
static readonly mapping: {[index: string]: string} | undefined = { | ||
"confirmation": "ConfirmationTrackingData", | ||
"estimation": "EstimationTrackingData", | ||
"internalReview": "InternalReviewTrackingData" | ||
}; | ||
static readonly mapping: {[index: string]: string} | undefined = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapping
for the discriminator has been removed. This is likely to cause deserialization errors at runtime. The objectSerializer
uses this mapping to determine which class to instantiate based on the value of the type
field in the JSON payload. Without this mapping, the deserializer might not be able to resolve polymorphic types correctly, especially if the values in the type
field (e.g., 'confirmation') do not exactly match the class names (e.g., 'ConfirmationTrackingData'). Please restore the mapping to ensure correct deserialization.
static readonly discriminator: string | undefined = "type";
static readonly mapping: {[index: string]: string} | undefined = {
"confirmation": "ConfirmationTrackingData",
"estimation": "EstimationTrackingData",
"internalReview": "InternalReviewTrackingData"
};
f50efa6
to
7e47e4f
Compare
3f2c303
to
d90d616
Compare
cdd3d9b
to
0d570d4
Compare
|
Breaking Changes 🛠
Checkout API
New
ShopperName
class has been introduced, to be used when defining the name of the shopper. This affects several classes:CreateCheckoutSessionRequest
,CreateCheckoutSessionResponse
,DonationPaymentRequest
,PaymentRequest
.The attribute
shopperName
has changed fromto
New Features 💎
Checkout API
PaymentDetails
add enumIris
UpiIntentDetails
add attributebillingSequenceNumber
UpiCollectDetails
make attributebillingSequenceNumber
optionalPaymentRequest
add attributesdkData
Classic Payments
Recurring
add enum valuesExternal
andOneclickrecurring
Payout API
ResponseAdditionalDataSwish
Management API
BR_SCHEMES
inPaymentMethodResponse
andPaymentMethodSetupInfo
Management Webhooks
TerminalAssignmentNotificationRequest
add attributeassignedToStoreId
dataReview
inVerificationError
andVerificationErrorRecursive
OpenAPI spec files or templates have been modified on 26-09-2025 by commit.