Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement RSACrypto #3

Open
5 of 11 tasks
StefanGreve opened this issue Jul 9, 2024 · 1 comment · May be fixed by #20
Open
5 of 11 tasks

Implement RSACrypto #3

StefanGreve opened this issue Jul 9, 2024 · 1 comment · May be fixed by #20
Assignees
@StefanGreve
Labels
documentation Improvements or additions to documentation enhancement New feature or request tests Work on test suite
Milestone
Version 8.0.0-alpha

Comments

@StefanGreve
Copy link
Member

StefanGreve commented Jul 9, 2024 •
edited
Loading

TODO

  • implement RSACryptoProvider
  • add IRSACryptoService
  • implement RSACryptoService
  • add RSACryptoOptions
  • implement AddRSACryptoService
  • test RSACryptoProvider
  • test RSACryptoService

Other Tasks

  • Add doc string for ICryptoRandomService interface
  • Add doc strings for IRSACryptoService
  • Add doc strings for RSACryptoProvider
  • Change the API for string message and string data to a (pinned) byte array

References

StackOverflow
@StefanGreve StefanGreve added documentation Improvements or additions to documentation enhancement New feature or request tests Work on test suite labels Jul 9, 2024
@StefanGreve StefanGreve added this to the Version 8.0.0-alpha milestone Jul 9, 2024
@StefanGreve StefanGreve self-assigned this Jul 9, 2024
@StefanGreve StefanGreve changed the title Implement RSACryptoServiceProvider Implement RSACrypto Jul 9, 2024
@StefanGreve
Copy link
Member Author

Notes: The RSACryptoService currently can throw an exception in the contructor:

 this._certificate = this._certificateService.GetConfiguredCertificate()
            ?? throw new ArgumentNullException(nameof(this._certificate));

Idea

Consider rewriting this code by moving the validation to a CertificateOptionsValidator (which implements IValidateOptions<CertificateOptions>). Add a certificate to the respective option and decorate this property with the IgnoreDataMember attribute to establish communication between the validator and the service.

@StefanGreve StefanGreve linked a pull request Feb 9, 2025 that will close this issue
Draft
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanGreve StefanGreve

Labels
documentation Improvements or additions to documentation enhancement New feature or request tests Work on test suite
Projects
None yet
Milestone
Version 8.0.0-alpha
Development

Successfully merging a pull request may close this issue.

RSA Encryption Advanced-Systems/security
1 participant
@StefanGreve