-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Setup (Part 1) #5
Draft
StefanGreve
wants to merge
21
commits into
master
Choose a base branch
from
project_setup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename region names * add doc strings to DatabaseOptions * remove IDatabaseConnectionServiceFactory and DatabaseConnectionServiceFactory * add IOptions<DatabaseOptions> to DatabaseConnectionService * update unit tests
* create DbCommandFactory (because dbConnection.CreateCommand cannot be mocked without this additional abstraction) * implement first unit test as proof of concept (ExecuteQuery) * add DbProvider.Generic (WIP) * add some more documentation via doc strings
* implement CreateDbDataAdapter method for DbProvider.Generic (DbCommand) in DbDataAdapterFactory * remove backup project file that was added in error in the test project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
Modify CI/CD scripts
documentation
Improvements or additions to documentation
enhancement
New feature or request
tests
Work on test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
docfx
#2DbConnectionService<T>
DbConnectionServiceFactory<T, U>
Makefile
AdvancedSystems.Security
)IDbConnectionService
IDbConnectionServiceFactory
Directory.Build.Props
needs any updatingreadme.md
Unit Tests (
DbConnectionService
)TestExecuteQuery
ExecuteQueryAsync
TestExecuteNonQuery
ExecuteNonQueryAsync
TestAddDbConnectionService_FromOptions
TestAddDbConnectionService_FromAppSettings
Unit Tests (
DatabaseConnectionFactory
)TestAddDbConnectionServiceFactory_FromOptions
TestAddDbConnectionServiceFactory_FromAppSettings
<T>
and<U>
Notes
MsSqlServerConnectionService
is tightly coupled to anSqlConnection
instance. Refactor theDatabaseConnectionFactory
appropriately to make writing unit tests feasible.Use an in-memory message bus for configuring a specific provider, then renameMsSqlServerConnectionService
toDatabaseConnectionService
and listen to the broadcast.Idea: Send a signal fromDatabaseConnectionFactory
to request a connection service as singletonMsSqlServerExtensions
toDatabaseExtensions
, and supply a more generic implementation ofCreateConnectionString
. Think about how this would affect theMsSqlServerSettings
... maybe rename it toMsSqlOptions
?DbOptionsFactory
(cf. WIP f4b111e)