test: add parser-safe validation for mock API modules - #399
Merged
Lakes41 merged 1 commit intoAug 21, 2026
Merged
Conversation
Keep domain boundaries explicit and verify each mock module parses in isolation so a syntax error in one domain cannot hide behind a monolithic aggregator. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MockAccessApimethods and aggregator re-exports stable for existing consumers (lib/api/index.ts,components/nav.tsx).Type of Change
Changes Made
lib/api/mock/domains.tsas the canonical domain/export registry.test/mock-api-structure.test.tsusing TypeScript syntactic diagnostics withnoResolve(parser-safe, no typecheck of imports).lib/api/mock/**/*.tsin the existing test tsconfig so domain modules participate in the current test pipeline.Acceptance Criteria
node:test+test/tsconfig.jsonconventions.Test Coverage
npx tsc -p test/tsconfig.json --skipLibChecknode --test test-dist/test/mock-api-structure.test.jsCloses #386
Made with Cursor