Skip to content

refactor: decouple mock API data into separate fixtures file and upda… #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lakes41 merged 1 commit into from
Aug 19, 2026
Merged

refactor: decouple mock API data into separate fixtures file and upda… #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 4 additions & 50 deletions app/[communitySlug]/admin/settings/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,18 @@ export default function SettingsPage() {
});

const queryClient = useQueryClient();
const { addToast } = useToasts();
const { toasts, addToast, dismissToast } = useToasts();
const [name, setName] = useState("");
const [approvalConfig, setApprovalConfig] = useState<ApprovalConfig>({ assignRole: 1, removeRole: 1, updatePolicy: 1 });

const updateConfigMutation = useMutation({
mutationFn: (config: ApprovalConfig) => getApi(undefined, undefined, communitySlug).updateApprovalConfig(config),
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: queryKeys.community.all(communitySlug) });
addToast({ title: "Configuration saved", description: "Approval thresholds have been updated.", variant: "success" });
addToast({ title: "Configuration saved", description: "Approval thresholds have been updated.", tone: "success" });
},
onError: () => {
addToast({ title: "Error", description: "Failed to update configuration.", variant: "destructive" });
addToast({ title: "Error", description: "Failed to update configuration.", tone: "error" });
}
});

Expand Down Expand Up @@ -71,52 +71,6 @@ export default function SettingsPage() {
</span>
</div>
</CardContent>
<Card>
<CardHeader>
<CardTitle>Workflow & Approvals</CardTitle>
</CardHeader>
<CardContent className="space-y-4">
<p className="text-sm text-muted-foreground mb-4">
Configure the number of admin approvals required before sensitive actions take effect. (1 = instant execution)
</p>
<div className="grid grid-cols-1 sm:grid-cols-3 gap-4">
<div className="space-y-2">
<label className="text-sm font-medium">Assign Role</label>
<Input
type="number"
min="1"
max="5"
value={approvalConfig.assignRole}
onChange={(e) => setApprovalConfig({ ...approvalConfig, assignRole: parseInt(e.target.value) || 1 })}
/>
</div>
<div className="space-y-2">
<label className="text-sm font-medium">Remove Role</label>
<Input
type="number"
min="1"
max="5"
value={approvalConfig.removeRole}
onChange={(e) => setApprovalConfig({ ...approvalConfig, removeRole: parseInt(e.target.value) || 1 })}
/>
</div>
<div className="space-y-2">
<label className="text-sm font-medium">Update Policy</label>
<Input
type="number"
min="1"
max="5"
value={approvalConfig.updatePolicy}
onChange={(e) => setApprovalConfig({ ...approvalConfig, updatePolicy: parseInt(e.target.value) || 1 })}
/>
</div>
</div>
<div className="pt-2">
<Button onClick={() => updateConfigMutation.mutate(approvalConfig)} disabled={updateConfigMutation.isPending}>
{updateConfigMutation.isPending ? "Saving..." : "Save Approvals"}
</Button>
</div>
</CardContent>
</Card>
<Card>
<CardHeader>
Expand Down Expand Up @@ -166,7 +120,7 @@ export default function SettingsPage() {
</CardContent>
</Card>
</div>
<ToastViewport />
<ToastViewport toasts={toasts} onDismiss={dismissToast} />
</AdminGuard>
</FeatureGate>
);
Expand Down
Loading