chore: add script to check for malformed build scripts - #352
Merged
Lakes41 merged 1 commit intoAug 20, 2026
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #333
Description
This PR introduces a script to check for malformed build scripts across all
package.jsonfiles in the monorepo. It specifically checks if build, typecheck, or lint scripts have accidentally been concatenated (e.g.,"build": "tsc -p tsconfig.json pnpm start pnpm typecheck pnpm lint"). This ensures workspace packages maintain clean, single-purpose script entries without cross-contamination.Linked Issue
Closes #
Type of Change
Changes Made
scripts/check-scripts.jsto recursively read all workspacepackage.jsonfiles and check for concatenated script anti-patterns.@guildpass/integration-client) currently have correctly isolated build, typecheck, and lint commands.Test Evidence
Running the new diagnostic script yields a clean bill of health across the workspace:
Checklist
pnpm typecheckpasses with no errorspnpm lintpasses (or issues are pre-existing and documented)pnpm testpasses (all existing tests still pass)pnpm dev:docs.env.exampleScreenshots / Recordings
N/A - CI/CLI Tooling change only.
Additional Notes
Initial investigation showed that
@guildpass/integration-clientand all other packages are currently clean on this branch. The addition of this script fulfills the acceptance criteria to have a repeatable check/checklist for this issue going forward.