Skip to content

chore: add script to check for malformed build scripts - #352

Merged
Lakes41 merged 1 commit into
Adamantine-guild:mainfrom
Opulencechuks:fix/malformed-build-scripts
Aug 20, 2026
Merged

chore: add script to check for malformed build scripts#352
Lakes41 merged 1 commit into
Adamantine-guild:mainfrom
Opulencechuks:fix/malformed-build-scripts

Conversation

@Opulencechuks

Copy link
Copy Markdown
Contributor

Closes #333

Description

This PR introduces a script to check for malformed build scripts across all package.json files in the monorepo. It specifically checks if build, typecheck, or lint scripts have accidentally been concatenated (e.g., "build": "tsc -p tsconfig.json pnpm start pnpm typecheck pnpm lint"). This ensures workspace packages maintain clean, single-purpose script entries without cross-contamination.

Linked Issue

Closes #

Type of Change

  • 🐛 Bug fix
  • ✨ New feature / enhancement
  • 📝 Documentation update
  • 🔧 Chore / refactor
  • 🧪 Tests only

Changes Made

  • Added scripts/check-scripts.js to recursively read all workspace package.json files and check for concatenated script anti-patterns.
  • Ran a workspace-wide verification which confirmed all existing packages (including @guildpass/integration-client) currently have correctly isolated build, typecheck, and lint commands.

Test Evidence

Running the new diagnostic script yields a clean bill of health across the workspace:

> node scripts/check-scripts.js
--- Malformed Scripts Report ---
No malformed scripts found! All build, typecheck, and lint scripts are clean and single-purpose.

Checklist

  • I have read CONTRIBUTING.md
  • This PR is linked to an open issue
  • pnpm typecheck passes with no errors
  • pnpm lint passes (or issues are pre-existing and documented)
  • pnpm test passes (all existing tests still pass)
  • The dashboard starts and renders correctly (if UI or API code changed)
  • The Discord bot still starts and responds to commands (if bot code changed)
  • Docs site renders correctly (if docs changed): pnpm dev:docs
  • No secrets, tokens, or API keys are included in this PR
  • Environment variable changes are reflected in .env.example
  • I have updated documentation if new behaviour was introduced

Screenshots / Recordings

N/A - CI/CLI Tooling change only.

Additional Notes

Initial investigation showed that @guildpass/integration-client and all other packages are currently clean on this branch. The addition of this script fulfills the acceptance criteria to have a repeatable check/checklist for this issue going forward.

@Lakes41
Lakes41 merged commit 94a5597 into Adamantine-guild:main Aug 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit and fix malformed build scripts across all workspace packages

2 participants