C19 Sapphire - Linh Huynh #36
Conversation
…ote code for instance methods named 'add' and 'remove'.
…hat are not in the inventory. Completed Wave 1.
…_wave_01.py. Also removed exception in last subtest and deleted @pytest.mark.skip lines before each subtest.
…nce named get_category.
…on (or subtest) in test_wave_02.py module
…ing representation of the item type and id.
…thod in vendor.py module.
…lse function of unit test_wave_03.py module. Also removed 'raise Exception' statement and all @pytest.mark.skip statments before each subtest/function.
…test_wave_03.py module. Re-pushing with the saved changes.
…in unit test_wave_04.py module.
…ethods for Clothing, Decor, and Electronics classes respectively in the clothing.py, decor.py, and electronics.py modules.
…onics classes respectively in the item.py, clothing.py, decor.py, and electronics.py modules.
…lass of the item.py module.
…ethods in Item class of item.py. Also updated the Clothing, Decor, and Electronic classes to include the attribute named condition in super().
… in the unit test_wave_05.py module.
…vendor.py module.
…n the vendor.py module.
… vendor.py module.
…ve_06.py module: test_get_no_matching_items_by_category, test_swap_best_by_category, test_swap_best_by_category_reordered, test_swap_best_by_category_no_match_is_false, and test_swap_best_by_category_no_other_match_is_false. Also removed all skip statements before each function.
…y, decor.py, and electronics.py modules.
tildeee
left a comment
tildeee
left a comment
There was a problem hiding this comment.
Great work on this project, Linh! It's marked as a "green" on my end.
Overall, your code looks great. Your code is well-written, readable, logical, straightforward, and clean. It's clear to me that you've put in effort to refactor. I wish I had more specific feedback for you, but really, overall I think you're writing good code and thinking about the right things! Keep it up!
In addition, your git hygiene looks great, and your tests look great, too!
As a small note, it looks like your swap-meet repo is a fork of AdaGold/swap-meet, instead of the expected Ada-C19/swap-meet. There's nothing to fix here for now, but I just thought I'd point that out to you.
Again, good work! Let me know what questions come up.
| class Vendor: | ||
| pass | ||
| def __init__(self, inventory = None): | ||
| self.inventory = [] if inventory is None else inventory |
There was a problem hiding this comment.
Nice post-fix conditional!
| def swap_first_item(self, other_vendor): | ||
| try: | ||
| return self.swap_items(other_vendor, self.inventory[0], other_vendor.inventory[0]) | ||
| except IndexError: |
There was a problem hiding this comment.
Nice IndexError catch! I like how the code looks here.
|
|
||
|
|
||
| def get_by_category(self, category): | ||
| return [item for item in self.inventory if item.get_category() == category] |
| 1: "Poor: High likelihood of abnormalities, defects, or irremovable stains you probably don't want to know about. Probably best to scavenge for parts.", | ||
| 2: "As-Is: Acceptable but of course, that's subjective. Consider at your own discretion.", | ||
| 3: "Good: Functional or wearable. What more could you ask for a discounted price?", | ||
| 4: "Gently worn: Practically like new. It's basically a steal. At least it's not cursed.", |
| 4: "Gently worn: Practically like new. It's basically a steal. At least it's not cursed.", | ||
| 5: "New: Pretty much in pristine condition with the added bonus of preventing existential crises and attracting good luck." | ||
| } | ||
| return condition_rating[self.condition] |
There was a problem hiding this comment.
I like the use of the dictionary/map
| # Initially wrote get_category instance method to return "Clothing". However, the code would be cleaner | ||
| # if I removed this instance method altogether, referenced the __str__ method instance in the Item class, | ||
| # and edited the return string in __str__ to remove any redundancy. |
There was a problem hiding this comment.
I think this is a good decision for this project/context!
3 participants
Thank you for reviewing my code. :)