-
Notifications
You must be signed in to change notification settings - Fork 638
Tigers - Masha & Soleil #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CheezItMan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done Masha & Soleil,
You hit the learning goals here. Well done. I like your tests for wave 7.
| @@ -0,0 +1,33 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably doesn't need to be committed.
| def __str__(self): | ||
| return "Hello World!" | ||
|
|
||
| def condition_description(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
| if not self.inventory or not any_list: | ||
| return None | ||
|
|
||
| return min(any_list, key=lambda item: item.age) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of a lambda!
We did Enhancements and added test_wave_07 as well to test it