feat(frontend): implement parseListing parse helper in frontend/src/lib/contracts.ts - #296
Open
TS-mfon wants to merge 3 commits into
Open
feat(frontend): implement parseListing parse helper in frontend/src/lib/contracts.ts#296TS-mfon wants to merge 3 commits into
TS-mfon wants to merge 3 commits into
Conversation
|
@TS-mfon is attempting to deploy a commit to the Ada's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@TS-mfon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
Please resolve conflict |
Owner
|
Please fix the conflict |
Author
|
…ation: resolve merge conflicts in contracts.ts and contracts.test.ts
Author
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #137
Summary of Work Done
Implemented
parseListingHelper:parseListing(rawData: Record<string, unknown>): MarketplaceListinginfrontend/src/lib/contracts.tsto convert the rawscValmap returned by the marketplace contract into a typedMarketplaceListinginterface object.id,bot_id,price, andlisted_atfields usingtoBigInt().Refactored Marketplace Listing Query Helpers:
getActiveListings()andgetUserListings()infrontend/src/lib/contracts.tsto utilize the newparseListinghelper function.Type Alias Support:
export type Listing = MarketplaceListing;infrontend/src/types/index.tsto support theListinginterface reference seamlessly.Testing & Verification:
frontend/src/lib/contracts.test.tscoveringparseListing,parseUserProfile, andparseBotNFT.npm run type-check) and Jest test runner (npm test), all passing.