Laura Robertson -- Carets #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Aug 16, 2017
|
|
||
| value.each do |index| | ||
| # For each matching key, it adds the value to the selected array | ||
| index.each {|key2,value2| cost_array << value2 if key2 == :cost} |
Collaborator
There was a problem hiding this comment.
This is kinda neat, but overly complicated.
You could instead do:
cost_array << value[:cost]Be careful about overly complicating things.
Collaborator
|
You organized the data well. I like how you created a hash with the Driver's ID as key and an array of trips (hashes) as the value. I did put a note in your code where you loop through the structure, it's a bit overly complicated. Overall very nicely done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.