Pipes - Kee - Static-Site

[anemonekey]

Static Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I had issues with titling sections. Most of the time I didn't have/want a title, so I switched many sections to divs. Also, I had a language issue so I had to add lang attributes here and there.
Why is it important to consider and use semantic HTML?	It creates an unspoken set of rules that makes it easy to understand others' code even upon first viewing.
How did you decide to structure your CSS?	I put more "universal" styles at the top as well as the repeated header and footer. Afterwards, I had a section for the changing "main" tag in each HTML file.
What was the most challenging piece of this assignment?	I think organizing CSS was the hardest. It would've been nice to have individual sheets as needed.
Describe one area that you gained more clarity on when completing this assignment	I learned more about semantic HTML which was very interesting and I think the takeaways helped me make more legible code. In addition, I learned more about organizing website elements. Also this made me appreciate Ruby linter more because CSS linter seemed very arbitrary at times.

[droberts-sea]

Static Site

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage	yes
Answered comprehension questions	yes - regarding question 2, semantic HTML is not only useful as a tool for developers, it also enables assistive technologies like screen readers
Page fully loads	yes
No broken links (regular or images)	yes
Includes at least 4 pages and styling	yes
HTML
Uses the high-level tags for organization: header, footer, main	yes
Appropriately using semantic tags: section, article, etc.	some of your files are good about this, but some of them are full of <div>s that could be converted into a more semantic tag
All images include alternate text	yes
CSS
Using class and ID names in style declarations	yes
Style declarations are DRY	yes
Organization	I like that you use comments to break up your CSS, but it still ends up being a very large and hard to navigate file. One useful technique here is to break your CSS into multiple files, one full of styles that apply to the entire site (like the header and footer), and a separate stylesheet for each individual page. Each page would need to link both the general styles and its own page-specific sheet. This makes things easier to keep track of, and helps prevent a change to one page unintentionally breaking another.
Overall	Beautiful site - I especially like the anchors in the nav bar. Great work!