Skip to content

Conversation

@tehut
Copy link

@tehut tehut commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? That some code may execute linearly while other code waits for event handlers.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? My reservation form only renders after the user clicks to see a single trip.
What kind of errors might the API give you? How did you choose to handle them? I only reported to the user whether or not thier reservation was made
What is an Underscore template? Describe one template you used for this project. Underscore templates are used to preformat and programatically create DOM elements. One of the changes I had to make was to move the reservation form out of its own template because the template could not see dom elements from outside the template
Do you have any recommendations on how we could improve this project for the next cohort?

@PilgrimMemoirs
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene ❗️ Should commit more often with more specific messages
Comprehension questions Well Done
Functionality
Click a button to list trips Well Done
Click a trip to see trip details Well Done
Fill out a form to reserve a spot Well Done
Errors are reported to the user Okay - Does for form, but not for if loading the trips or single trip fails
Styling, Foundation grid layout Well Done
Under the Hood
Trip data is retrieved using jQuery AJAX Well Done
JavaScript is well-organized and easy to read - Some functions are getting long - like showTrip().
HTML is semantic Mostly Good - for the list of trips, each trip is in an article tag but only has a single element. A Better option for that could be li, since it is part of a list and has a small amount of content.
All dynamic content is rendered using Underscore templates Well Done
Overall
Nice work with all the required features! This submission meets the expectations and learning goals for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants