Skip to content

Conversation

@TamikoT
Copy link

@TamikoT TamikoT commented May 12, 2017

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? Read the online documentation and use Postman to see the response.
Describe your API Wrapper. How did you decide on the methods you created? I created an API wrapper that created Recipe object.
Describe an edge case or failure case test you wrote for your API Wrapper.
Explain how VCR aids in testing an API.
What is the Heroku URL of your deployed application?
Do you have any recommendations on how we could improve this project for the next cohort?

@droberts-sea
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions some
General
Rails fundamentals (RESTful routing, use of named paths) yes
Semantic HTML yes - good work!
Errors are reported to the user no - This should be one of the first things you do when you set up a new project (for example by adding code to display flash messages to application.html.erb). It will save you a lot of trouble in the long run.
API Wrapper to handle the API requests yes
Controller testing some - I would like to see more testing in general, both for controllers and for the lib files. Interesting questions that might be asked by your tests include "What happens if my search returns 0 results" and "What happens if I try to show a recipe that doesn't exist".
Styling
Foundation Styling for responsive layout yes - good work
Search View yes
List View yes
Show View which opens in a new tab yes
API Features
The App attributes Edaman yes
The VCR casettes do not contain the API key yes
Overall

Good work overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants