Queues - Andrea Valliere - API Muncher

[avalliere]

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
How did you go about exploring the Edamam API, how did you try querying the API?	I spent time reading the documentation and using Postman to try out different queries with different parameters.
Describe your API Wrapper. How did you decide on the methods you created?	I have a method that runs the search query and returns data in a format I can use and I have an initialize method. I think there may have been a better way to use the API wrapper, but this was how I managed to get it to work and understand the code.
Describe an edge case or failure case test you wrote for your API Wrapper.	No tests written yet
Explain how VCR aids in testing an API.	It allows you to test without making a new query to the API each time
What is the Heroku URL of your deployed application?	Not yet deployed
Do you have any recommendations on how we could improve this project for the next cohort?

[PilgrimMemoirs]

API Muncher

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Well Done
Comprehension questions	Mostly Good - if you haven't done something yet, like an edge case test, also provide what you would have done.
General
Rails fundamentals (RESTful routing, use of named paths)	Well Done
Semantic HTML	❗️ None used - None of the elements are organized by semantic sectioning tags
Errors are reported to the user	❗️ None.
API Wrapper to handle the API requests	Well Done for getting list of recipes, ❗️not complete for querying a single, specific recipe
Controller testing	❗️ Started but not completed - only has positive case for index and show.
Styling
Foundation Styling for responsive layout	❗️ A little - recipes index. It should be used more in the layouts, especially with the recipe's show page. The list of recipes in index would have been a good opportunity to use foundation's block grid.
Search View	Only has form - would like to see more content and styling applied to this view
List View	Shows list - has basic html content and some use of foundation grid.
Show View which opens in a new tab	Code is setup to do so in the view, but cannot see since show is not working
API Features
The App attributes Edaman	❗️ Not done
The VCR casettes do not contain the API key	❗️ Not completed
Overall
	Nice work setting up pagination.
lib testing	❗️ There are not any tests or cassettes setup for the wrapper and api calls.
Recipe Show	❗️ The controller is calling a method called 'search' on the wrapper, although there is no method defined in the wrapper with that name and the show page is broken. Did you not get to this functionality, or did you forget to push it? If you do have it, let me know.
	While you have a good chunk of the application's functionality working, there are a lot of requirements still missing from this project that raises concerns. Especially things that should be review (ex: html, foundation, controller testing). Not having lib tests or the show for the recipe also raises a huge concern, it does look like you have a good amount of it setup, but it's interesting that the wrapper is missing the method to complete it from working.